Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix struct accessors in tutorial examples #1809

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Jan 22, 2024

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (ad6640e) to head (55c85c9).

Current head 55c85c9 differs from pull request most recent head b2da2ae

Please upload reports for the commit b2da2ae to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
+ Coverage   79.06%   84.78%   +5.72%     
==========================================
  Files         466       55     -411     
  Lines       53493     5659   -47834     
==========================================
- Hits        42294     4798   -37496     
+ Misses      11199      861   -10338     

see 448 files with indirect coverage changes

@jaychia jaychia enabled auto-merge (squash) May 20, 2024 17:54
Copy link

codspeed-hq bot commented Aug 29, 2024

CodSpeed Performance Report

Merging #1809 will degrade performances by 39.73%

Comparing jay/fix-struct-accessors (760980a) with main (36401ab)

Summary

❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jay/fix-struct-accessors Change
test_show[100 Small Files] 364.1 ms 604.1 ms -39.73%

@jaychia jaychia merged commit dee1af8 into main Aug 29, 2024
34 of 35 checks passed
@jaychia jaychia deleted the jay/fix-struct-accessors branch August 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant